Fix dark theme scrollbar colors customizations pages - #333634
Merged
Jessie Houghton (houghj16) merged 9 commits intoSep 1, 2026
Merged
Conversation
Copilot started reviewing on behalf of
Jessie Houghton (houghj16)
August 31, 2026 20:30
View session
Jessie Houghton (houghj16)
enabled auto-merge
August 31, 2026 20:30
Jessie Houghton (houghj16)
requested a review
from Hawk Ticehurst (hawkticehurst)
August 31, 2026 20:30
Jessie Houghton (houghj16)
disabled auto-merge
August 31, 2026 20:32
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: 3
New issues introduced by this change (3)
| Severity | Finding |
|---|---|
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts — Keyboard navigation can now desynchronize the themed scrollbar. CustomizationCardListController… |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts — Keyboard focus can scroll cardContainer natively without updating DomScrollableElement's model.… |
|
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts — The existing PluginsTabScrolled component fixture calls revealLastItem() and resolves… |
What changed in this PR
Replaces native scrollbars on customization and plugin card pages with VS Code’s themed overlay scrollbar.
Changes:
- Added
DomScrollableElementwrappers and scroll handling. - Added content/layout rescanning.
- Added scrollbar gutter and wrapper styling.
| File | Description |
|---|---|
aiCustomizationListWidget.ts |
Adds themed card scrolling. |
pluginListWidget.ts |
Adds themed scrolling across plugin surfaces. |
aiCustomizationManagement.css |
Defines overlay layout and gutter spacing. |
Suppressed comments (3)
src/vs/workbench/contrib/chat/browser/aiCustomization/aiCustomizationListWidget.ts:800
- Pass the containing window to
DisposableResizeObserver. Without it, the observer is constructed inmainWindow; when this editor is hosted in an auxiliary window, the new card scrollbar will not be observed in the correct DOM realm. Nearby observers already use this pattern (aiCustomizationListWidget.ts:725-739,aiCustomizationManagementEditor.ts:899-905).
const cardResizeObserver = this._register(new DOM.DisposableResizeObserver(
'AICustomizationListWidget.cardScrollable',
() => this.cardScrollable.scanDomNode(),
));
this._register(cardResizeObserver.observe(this.cardScrollableNode));
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts:879
- Pass
DOM.getWindow(this.cardScrollableNode)to this observer. The default ismainWindow, so plugin cards opened in an auxiliary editor window use aResizeObserverfrom the wrong realm; the other observers in this widget already passDOM.getWindow(this.element)(pluginListWidget.ts:704-708,754-765).
const cardResizeObserver = this._register(new DOM.DisposableResizeObserver(
'PluginListWidget.cardScrollable',
() => this.cardScrollable.scanDomNode(),
));
this._register(cardResizeObserver.observe(this.cardScrollableNode));
src/vs/workbench/contrib/chat/browser/aiCustomization/pluginListWidget.ts:1216
- This per-content observer also defaults to
mainWindow. SincecreateCardScrollContentruns after the widget may have been mounted in an auxiliary window, passDOM.getWindow(content)so dynamic card height changes are observed in the containing realm.
const resizeObserver = this.cardDisposables.add(new DOM.DisposableResizeObserver(
'PluginListWidget.cardScrollContent',
() => this.cardScrollable.scanDomNode(),
));
this.cardDisposables.add(resizeObserver.observe(content));
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Match the customization card scrollbar spacing and reuse the themed overlay scrollbar for MCP server cards.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jessie Houghton (houghj16)
enabled auto-merge
August 31, 2026 21:22
Jessie Houghton (houghj16)
disabled auto-merge
August 31, 2026 21:47
Hawk Ticehurst (hawkticehurst)
previously approved these changes
Sep 1, 2026
Ladislau Szomoru (lszomoru)
previously approved these changes
Sep 1, 2026
Jessie Houghton (houghj16)
enabled auto-merge
September 1, 2026 15:13
Give the scrolled fixtures enough virtual time for the scrollbar hide and fade wait to complete. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Jessie Houghton (houghj16)
dismissed stale reviews from Ladislau Szomoru (lszomoru) and Hawk Ticehurst (hawkticehurst)
via
September 1, 2026 20:32
04e12ec
Dmitriy Vasyura (dmitrivMS)
previously approved these changes
Sep 1, 2026
Jessie Houghton (houghj16)
disabled auto-merge
September 1, 2026 20:56
Jessie Houghton (houghj16)
enabled auto-merge (squash)
September 1, 2026 20:56
roblourens
approved these changes
Sep 1, 2026
Jessie Houghton (houghj16)
disabled auto-merge
September 1, 2026 21:30
Jessie Houghton (houghj16)
enabled auto-merge (squash)
September 1, 2026 21:30
Jessie Houghton (houghj16)
disabled auto-merge
September 1, 2026 21:31
Jessie Houghton (houghj16)
deleted the
agents/fix-dark-theme-scrollbar-colors
branch
September 1, 2026 21:31
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #333544
Fixes #333639
Before:
After:
This pull request addresses the scrollbar styling for the customizations and plugins pages to ensure they align with the dark theme colors and layout requirements. Key changes include:
DomScrollableElement) for both the customizations and plugins pages.All changes have been validated with successful client compiles, CSS lint checks, and live DOM inspections in Code OSS.